Skip to content

Slammer integration into WLS Operator tests #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 16, 2021
Merged

Slammer integration into WLS Operator tests #2536

merged 15 commits into from
Sep 16, 2021

Conversation

marinakog
Copy link
Member

@marinakog marinakog commented Sep 14, 2021

https://confluence.****/confluence/display/WLSQA/Chaos+integration+with+WLS+Operator+tests

http://****:8090/view/weblogic-operator/job/weblogic-kubernetes-operator-resilience/57/

@@ -0,0 +1,179 @@
// Copyright (c) 2020, 2021, Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2020 here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,240 @@
// Copyright (c) 2020, 2021, Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2020 here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,162 @@
// Copyright (c) 2020, 2021, Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2020 here

@@ -0,0 +1,195 @@
// Copyright (c) 2020, 2021, Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2020 here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@marinakog marinakog requested a review from xiancao September 14, 2021 20:51
//check if slammer is up
assertTrue(Slammer.list("network"), "Can't reach slammer");
// get namespaces
assertNotNull(namespaces.get(0), String.format("Namespace namespaces.get(0) is null"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use String.format() or use String.format("Namespace %s is null", namespaces.get(0))

assertNotNull(namespaces.get(0), String.format("Namespace namespaces.get(0) is null"));
opNamespace = namespaces.get(0);

assertNotNull(namespaces.get(1), String.format("Namespace namespaces.get(1) is null"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use String.format() or use String.format("Namespace %s is null", namespaces.get(1))

Copy link
Member

@xiancao xiancao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rjeberhard rjeberhard merged commit 2da56fe into main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants